Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added release highlights to ESQL #100191

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Added release highlights to ESQL #100191

merged 3 commits into from
Oct 5, 2023

Conversation

craigtaverner
Copy link
Contributor

The original PR was labeled release highlight but did not yet have the highlight text. This PR adds a first draft of that text, extracted from the ESQL blog.

@craigtaverner craigtaverner added >docs General docs changes Team:QL (Deprecated) Meta label for query languages team :Analytics/ES|QL AKA ESQL v8.11.0 labels Oct 3, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Oct 3, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

craigtaverner
craigtaverner commented Oct 3, 2023
View reviewed changes
docs/changelog/98309.yaml Outdated
@@ -3,3 +3,31 @@ summary: "Integrate Elasticsearch Query Language, ES|QL"
area: Query Languages
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this to ES|QL to match all other ES|QL PR's (right now this is the only ES|QL PR in Query Languages)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@craigtaverner craigtaverner mentioned this pull request Oct 3, 2023
Closed
13 tasks
alex-spies
alex-spies approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, I just proof-read this for good measure; LGTM. Since this is already coming from a blog post that was certainly iterated on, I didn't really find anything except one small remark.

docs/changelog/98309.yaml Outdated
and use queries to create custom alerts.

[role="screenshot"]
image:images/esql/illustration_esql_kibana_wireframe.png[ES|QL usage in Kibana Discover]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That wire frame doesn't look too close to how ESQL looks in Kibana these days; should this maybe use a more up-to-date picture?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

@elasticsearchmachine
Copy link
Collaborator

Hi @craigtaverner, I've created a changelog YAML for you. Note that since this PR is labelled release highlight, you need to update the changelog YAML to fill out the extended information sections.

@craigtaverner
Added release highlights to ESQL
16b6d18 
The original PR was labeled `release highlight` but did not yet have the highlight text.
This PR adds a first draft of that text, extracted from the ESQL blog.
@craigtaverner craigtaverner force-pushed the esql_release_highlight branch from ff64e1d to 16b6d18 Compare October 5, 2023 09:30
@craigtaverner craigtaverner changed the base branch from main to 8.11 October 5, 2023 09:30
@elasticsearchmachine
Copy link
Collaborator

Hi @craigtaverner, I've created a changelog YAML for you. Note that since this PR is labelled release highlight, you need to update the changelog YAML to fill out the extended information sections.

@craigtaverner craigtaverner force-pushed the esql_release_highlight branch from ebf6c37 to 16b6d18 Compare October 5, 2023 10:17
@craigtaverner
Add new screenshot for kibana ESQL
2184b60
@craigtaverner
Remove ESQL prefix from all ESQL changelog entries
7313149 
Unlike the original PR's these entries are sorted under an `ES|QL` subsection, so this is redundant, and visually jarring.
@craigtaverner craigtaverner merged commit fc84f70 into elastic:8.11 Oct 5, 2023
@craigtaverner craigtaverner deleted the esql_release_highlight branch October 20, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-spies alex-spies alex-spies approved these changes

@ChrisHegarty ChrisHegarty Awaiting requested review from ChrisHegarty

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL >docs General docs changes Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@craigtaverner @elasticsearchmachine @alex-spies @mattc58